cmake: fix manylinux wheel builds #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manylinux does not ship with the "Development.Embed" component's static Python libraries, which are implied in the "Development" component, hence builds fail. Those libraries are not needed to build extension modules: scikit-build/scikit-build-core#173 The "Development.Module" is sufficient for building modules: https://cmake.org/cmake/help/latest/module/FindPython.html Signed-off-by: MichaIng <micha@dietpi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manylinux does not ship with the
Development.Embedcomponent's static Python libraries, which are implied in theDevelopmentcomponent, hence builds fail. Those libraries are not needed to build extension modules: scikit-build/scikit-build-core#173The
Development.Modulesub-component is sufficient for building modules: https://cmake.org/cmake/help/latest/module/FindPython.htmlFurther references about these sub-components added with cmake 3.18 exactly for the manylinux + cmake combination:
Enabling wheel builds with manylinux allows to use cibuildwheel for building multi-platform and multi-arch wheels and potentially making them available on PyPI.