Skip to content

Conversation

@mcoirault
Copy link
Contributor

@mcoirault mcoirault commented Jul 29, 2025

Ajusted the sjis encoder/decoder to match 81 40 with space, and 81 44 with period.

Added logic+UI to handle icon.sys' linebreak.

Refactored icon_sys_viewer::file_select() and title_cfg_viewer::value_select() into a unified component.

pub fn value_select(
    ui: &mut Ui,
    name: impl Into<String>,
    selected_value: &mut String,
    values: &[String],
) -> Response

The component returns the Response of the underlying text field.

Add warning messages to icon.sys tab to warn against lengthy title/filenames.

Improve icon.sys UI alignment and standardize toolbar sizes across all tabs.

@mcoirault mcoirault force-pushed the fix-sjis-encoding-and-ui-tweaks branch from 87d1bce to 90fea48 Compare July 29, 2025 13:00
@mcoirault mcoirault force-pushed the fix-sjis-encoding-and-ui-tweaks branch from 0610ca2 to 5e97277 Compare July 29, 2025 19:00
@mcoirault mcoirault marked this pull request as ready for review July 29, 2025 20:10
@saildot4k saildot4k merged commit 88f6680 into main Oct 29, 2025
3 checks passed
@saildot4k saildot4k deleted the fix-sjis-encoding-and-ui-tweaks branch October 29, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants