Skip to content

Conversation

@depfu
Copy link

@depfu depfu bot commented Aug 7, 2018


Welcome to Depfu πŸ‘‹

This is one of the first three pull requests with dependency updates we've sent your way. We tried to start with a few easy patch-level updates. Hopefully your tests will pass and you can merge this pull request without too much risk. This should give you an idea how Depfu works in general.

After you merge your first pull request, we'll send you a few more. We'll never open more than seven PRs at the same time so you're not getting overwhelmed with updates.

Let us know if you have any questions. Thanks so much for giving Depfu a try!



🚨 Your version of nokogiri has known security vulnerabilities 🚨

Advisory: CVE-2018-8048
Disclosed: March 29, 2018
URL: https://github.com/sparklemotion/nokogiri/pull/1746

Revert libxml2 behavior in Nokogiri gem that could cause XSS

[MRI] Behavior in libxml2 has been reverted which caused
CVE-2018-8048 (loofah gem), CVE-2018-3740 (sanitize gem), and
CVE-2018-3741 (rails-html-sanitizer gem). The commit in question is
here:

GNOME/libxml2@960f0e2

and more information is available about this commit and its impact
here:

flavorjones/loofah#144

This release simply reverts the libxml2 commit in question to protect
users of Nokogiri's vendored libraries from similar vulnerabilities.

If you're offended by what happened here, I'd kindly ask that you
comment on the upstream bug report here:

https://bugzilla.gnome.org/show_bug.cgi?id=769760


🚨 We recommend to merge and deploy this update as soon as possible! 🚨

We've updated a dependency and here is what you need to know:

name version specification old version new version
nokogiri indirect dependency 1.8.2 1.8.4

You should probably take a good look at the info here and the test results before merging this pull request, of course.

What changed?

↗️ nokogiri (indirect, 1.8.2 β†’ 1.8.4) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

Depfu Status

@depfu depfu bot added the depfu label Aug 7, 2018
@depfu
Copy link
Author

depfu bot commented Oct 5, 2018

Closed in favor of #27.


Automated by Depfu.

@depfu depfu bot closed this Oct 5, 2018
@depfu depfu bot deleted the depfu/update/nokogiri-1.8.4 branch October 5, 2018 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant