fix: schema compilation wasn't adding ON CLUSTER, causing false diffs #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing schemas, we were getting false positives about cluster changes even though nothing actually changed.
The problem:
ON CLUSTERclausesON CLUSTERclausesReproduction steps:
Expected result:
Second
housekeeper difffinds no differencesActual result:
Second
housekeeper difffails withcannot change cluster from 'cluster' to '': cluster configuration changes not supportederrorThe fix:
Moved the InjectOnCluster function to pkg/parser so both paths can use it:
parser.InjectOnClustercompileProjectSchemanow also callsparser.InjectOnClusterwhen compiling schemaNow both schema extraction and compilation add ON CLUSTER the same way, so we don't get fake diffs anymore
Additional impact:
ON CLUSTERinto statements