Improved the Syntax error Message #4847
Conversation
|
But not all syntax errors mean you're missing a colon... |
|
@cobaltt7 You can check the latest commit! |
src/black/parsing.py
Outdated
| f"Line {lineno}, Column {column}\n" | ||
| f"\n {faulty_line}\n" | ||
| f" {' ' * (column - 1)}^\n" | ||
| f"\nMissing a ':' or Invalid Syntax\n" |
There was a problem hiding this comment.
Remove this line, it is likely to be misleading.
jyotiv06
force-pushed
the
improve-syntax-error-output
branch
2 times, most recently
from
49f8219 to
a37b065
Compare
|
This is not an improvement. It removes information that was previously included (line number & column). Jelle and I wanted the last line removed, because not all syntax errors are caused by missing semicolons, and what you had previously implied that most syntax errors were. Take a look at the attributes of ParseError and see what would be helpful to log out. There may also be an opportunity to improve the TokenError message a few lines below, I'm not sure. |
|
Closing because this isn't an improvement. Please feel free to open a new PR following my feedback above |
3 participants
Fixes #4820
I validated the Following error message
I enhanced the Error reporting message to be more clear!
I'm happy to revise this PR if needed. Please let me know if there are any changes or improvements you'd like.