add embargo option for liberal arts grad students #960
+210
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smullz622
commented
Jan 6, 2026
jlandiseigsti
previously approved these changes
Jan 12, 2026
Contributor
jlandiseigsti
left a comment
jlandiseigsti
left a comment
There was a problem hiding this comment.
Looks good! A few small questions about the tests
| end | ||
|
|
||
| context 'when author is in college of liberal arts' do | ||
| unless current_partner.milsch? |
Contributor
There was a problem hiding this comment.
This should only be true for graduate, right? Maybe if current_partner.graduate? would be better to make that explicit?
| end | ||
|
|
||
| context 'when graduate author is in college of liberal arts' do | ||
| unless current_partner.honors? |
Contributor
There was a problem hiding this comment.
Same thought as above.
spec/models/submission_spec.rb
Outdated
| access_level: 'restricted_liberal_arts' | ||
| end | ||
|
|
||
| it 'returns submissions that are ready for autorelease' do |
Contributor
There was a problem hiding this comment.
Is this description accurate?
…nstitution facets to solr indexing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #912
Waiting to merge until we get confirmation from the LionPath team that they are ready for this to be live