Close all open websocket connections when server is suspended #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spended When a server status switches to suspended, immediately close any open websocket connections. Additionally, the websocket message handler will fail immediately if the server is suspended and a message is received. Also blocks API requests from even establishing a websocket connection when the server is already suspended. Noticed a bug in the context cancelation behavior that was running all of the close logic, but never actually killing the loop so the connection just sat there open. This is going to require some tweaks in the panel too — right now when you do this it just sits there flooding the `/ws` endpoint because it doesn't know how to handle this specific case.
…t for the connection
|
Tested on my local instance, it works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that all connections close immediately when a server is suspended or deleted. If for whatever reason a message is able to make it to the handler, it will immediately fail without processing if the server is suspended as well.
Confirmed server suspension and deletion both disconnect as expected. There is a follow-up bug in the Panel code to fix the back-off logic to not keep retrying when the error response is a
4xxerror code. It does this for both deletion and suspension, so at least it is consistently... poor. 🎉resolves pterodactyl/panel#5281