-
Notifications
You must be signed in to change notification settings - Fork 62
Changes from async-kwik
#82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The license header was stripped, a violation of @ptrd's copyright by distributing this code. The diff of the related commit was quite large, but it appeared to not have any other similar violations, so I believe this is the only one. Related-to: 95504d9 Signed-off-by: Mahied Maruf <contact@mechite.com>
This reverts commit 95504d9. Signed-off-by: Mahied Maruf <contact@mechite.com>
Signed-off-by: Mahied Maruf <contact@mechite.com>
Related-to: 6f2c8ce Signed-off-by: Mahied Maruf <contact@mechite.com>
Update all usages to use the accessor methods. Signed-off-by: Mahied Maruf <contact@mechite.com>
- Explicit type over `var` - Variable name `listener` instead of `l` - Reduce one level of nesting Signed-off-by: Mahied Maruf <contact@mechite.com>
This was added to the h09 module and seems to not be necessary. Signed-off-by: Mahied Maruf <contact@mechite.com>
Signed-off-by: Mahied Maruf <contact@mechite.com>
Signed-off-by: Mahied Maruf <contact@mechite.com>
This moves the pool to the `QuicStreamImpl`, but still continues to be a package-private implementation detail. Signed-off-by: Mahied Maruf <contact@mechite.com>
This change copies the OpenJDK 19+ default close method in `ListenerThreadPool` (for support of older versions). The `QuicStream#close` method here does not follow the existing TODO comment, only closes the new `ListenerThreadPool`. Signed-off-by: Mahied Maruf <contact@mechite.com>
This is equivalent, available since JDK 1.5, and simpler. Signed-off-by: Mahied Maruf <contact@mechite.com>
This does not appear to have been ever written to, only ever read from. It was also never guarded against multi-threaded access. This patch also makes `ListenerThreadPool implements Executor` as a result of the stream no longer being tracked. Signed-off-by: Mahied Maruf <contact@mechite.com>
|
I could not get the build system working properly to run all tests, but I resolved all conflicts and minimized the patch. @odanielmeinicke 6121bb2 shows a bug in your code? |
Signed-off-by: Mahied Maruf <contact@mechite.com>
Signed-off-by: Mahied Maruf <contact@mechite.com>
grep of `== true` and `== false` in the project returns no other results, so this is the only one. Signed-off-by: Mahied Maruf <contact@mechite.com>
This merges two files as-is from the related PR. It then uses the new `VirtualExecutor` system where the single-thread executor was previously being used as part of these async changes. Related-to: ptrd#74 Co-authored-by: Josiah Noel <32279667+SentryMan@users.noreply.github.com> Signed-off-by: Mahied Maruf <contact@mechite.com>
|
Hi, i appreciate the time you spent on my As this code is a pure jerry-rig, we can collab each other and create something more elaborated for Kwik. Feel free to contact me in that case. ME, PERSONALLY, the original creator of these changes DON'T recommend these changes (That's why i didn't pulled originally. Not because of the bugs, that can be tested; but because the mechanic of the listeners as interfaces, there's similar, but better ways to do that) for the official Kwik library. Again, thank you for your time, you really made a good work. I analyzed every commit. Also:
Not exactly, but yes. That's an incomplete feature to prevent stack overflow. As example: If i do a |
|
I think with proper testing the changes should be acceptable. I'll be honest and say that the long/verbose method names like I think that the design of Kwik being the way it is, is probably just because of time constraints. I just wanted to keep this PR down to:
...as this can maybe make Kwik scale up more. Then, maybe in seperate PRs:
|
Enumeration of changes from
async-kwik.This is a draft PR as a cleanup of the very big patch @odanielmeinicke made
Signed-off-by: Mahied Maruf <contact@mechite.com>