Skip to content

test for jest conversion #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jywarren merged 4 commits into from
Dec 21, 2021
Merged

test for jest conversion #767

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba2f56c
test for jest conversion
jywarren Dec 21, 2021
ca2aafd
Update publishButton.test.js
jywarren Dec 21, 2021
81777b7
Update publishButton.test.js
jywarren Dec 21, 2021
6f83b8a
Update publishButton.test.js
jywarren Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions test/ui-testing/publishButton.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,16 @@ beforeAll(async () => {

describe('Publish button', () => {

test('something we are testing described here', () => {

test('Publish button is enabled', async () => {
// Check initially that Publish button is disabled.
expect(await page.evaluate(() => document.querySelector('.ple-publish').disabled)).toBe(true);
// Add title.
await page.evaluate(() => {
document.querySelector('.ple-module-title input').value = 'A title';
document.querySelector('.ple-module-title input').dispatchEvent(new KeyboardEvent('keydown', { "code": "9" })); // random key
});
// Check final state of Publish button.
expect(await page.evaluate(() => document.querySelector('.ple-publish').disabled)).toBe(false);
});
Copy link
Collaborator

@NARUDESIGNS NARUDESIGNS Dec 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jywarren I noticed you didn't add the timeout variable here. Is this part of the new change or is it something you missed out?

Copy link
Member Author

@jywarren jywarren Dec 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was able to set it globally on the first few lines and so didn't need to set it per-test.

Copy link
Member Author

@jywarren jywarren Dec 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, interesting, actually on checking, I am not setting the timeout. I think that means we could remove that line, actually.

For reference, I'm stuck on a related issue (going past the timeout limit in this case) in this test publiclab/image-sequencer#2026

https://github.com/publiclab/image-sequencer/blob/58eb3ef6b1caba88aaf217d93ec085a14765d8aa/test/ui-2/test/OverlayInput.test.js#L1-L12

That actually is globally setting timeout. But here I think i just removed it and for the purposes of our test it wasn't needed. I think the default timeout is 5 or 10 seconds? So i guess that's enough for this.


});