bump to 3.7.1 w /dist/ files compiled, yarn.lock removed, updated release workflow issue template #2036

jywarren · 2022-01-15T17:38:29Z

Fixes #1751, fixes #2035

open an issue using the "release" template with this checklist with title Checklist and coordination for v0.0.0 major/minor/patch release (see semantic versioning)
create a release project from this template. You can copy a project from its menu.
compile release notes below from corresponding release project.
open a pull request with updated version numbers
- update version number in examples/sw.js (ex Bump lockfile and sw.js versions for v3.6.0 #1734) and package.json (ex Bump to v3.6.0 for new npm release #1695)
- update version number in package.json
- run npm install to update package-lock.json (from recent node version - 16 at time of writing, in GitPod should work)
finalize and merge to main branch (freeze merges to main branch until next step)

Now, move to stable branch:

force push from main to stable
then in stable branch, compile /dist/ files with grunt build
add /dist/ files with git add -f /dist/* and commit them to stable branch
run npm publish

Draft a release:

create a release on GitHub and use features description + release notes from below
tag version number branch (i.e. v0.0.0) based on stable or choose stable
publish tagged branch to npm with npm publish (logging in first as necessary)
publish to live Github pages demo (with bash script from /scripts/update-demo) (from within GitPod works well)
move anything necessary to next release project, i.e. https://github.com/publiclab/image-sequencer/projects/[insert project number]
close this issue!

Noting we're now in this process in #1751 for v3.7.0.

Release notes

Added

New Shadow Module: Add shadows (borders) to images in bulk! New Shadow module #1507 by @niravasher
New Alpha masking module: Alpha masking module #1546 by @blurry-x-face
New sharpness module in Module for sharpening images #1612 by @waridrox

Fixed

compiled /dist/ files from v3.7.0
Percentage Parsing: Percentage values passed to the sequencer are now parsed more consistently. (Parse floating-point value from percentages #1733)
Safari Fix: Image Sequencer will now work in the Safari browser! (Upgrade picomatch so image-sequencer works in Safari #1740)
offline caching improvements in Offline caching: Try To fetch latest data first then shift to cached one. #1819 and -fixed registration problem of service worker #1807 by @vivek-30
variety of other bugfixes!
fixed Module selector console error Fixes Module Selector Console Error #1543 by @ss62171

Changed

switch to GitHub Actions in try moving to Github Actions from Travis for CI #1783 (team effort!)
switch to expr-eval in switch to expr-eval for dynamic module #1729 by @jywarren
CLI improvements in refactor cli code #1785 by @blurry-x-face
dependencies updated
yarn.lock removed yarn.lock vs. package-lock.json #2035

gitpod-io · 2022-01-15T17:38:33Z

jywarren · 2022-01-15T17:41:52Z

Tests failing with:

npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!

Ah, interesting:

npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/jywarren/imgareaselect.git
npm ERR! 
npm ERR! Warning: Permanently added the RSA host key for IP address '140.82.114.4' to the list of known hosts.
npm ERR! git@github.com: Permission denied (publickey).
npm ERR! fatal: Could not read from remote repository.
npm ERR! 
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
npm ERR! 
npm ERR! exited with error code: 128

jywarren · 2022-01-15T17:44:37Z

Ah, it's wrong in the package-lock.json file. I'm removing and reinstalling it to get the correct URL format.

jywarren · 2022-01-15T17:58:01Z

Hmm, this:

"imgareaselect": "https://github.com/jywarren/imgareaselect.git#v1.0.0-rc.2",

Generates this:

    "node_modules/imgareaselect": {
      "version": "0.9.11-rc.1",
      "resolved": "git+ssh://git@github.com/jywarren/imgareaselect.git#db8ae869ca0fcb289252678cebd17d6f40711f61"
    },

and

    "imgareaselect": {
      "version": "git+ssh://git@github.com/jywarren/imgareaselect.git#db8ae869ca0fcb289252678cebd17d6f40711f61",
      "from": "imgareaselect@https://github.com/jywarren/imgareaselect.git#v1.0.0-rc.2"
    },

I guess I'm surprised that although I specify https:// it seems to still by trying to use ssh? git+ssh://git@github.com/jywarren/imgareaselect.git

jywarren · 2022-01-15T18:01:07Z

OK noting an old convo at npm repo about defaulting to git+ssh:// if ambiguity, so will try specifying more narrowly git+https:// npm/npm#7302 (comment) as well as searching for more recent docs on this in NPM...

jywarren · 2022-01-15T18:05:45Z

This seems still open - npm uses ssh, even when dependency is specified with https

npm uses ssh, even when dependency is specified with https npm/npm#19168 and precisely this issue as far as i can see - we're on node 16

jywarren · 2022-01-15T18:12:16Z

Aha - it's this: npm/cli#2610

Some are saying it's still not fixed in npm v8.1, so i'm reading the comments for a workaround.

jywarren · 2022-01-15T18:25:01Z

Huh, ok, so got past the ssh/https issue and now:

Expand logs

Running "browserify:tests" (browserify) task
>> Error: Parsing file /home/runner/work/image-sequencer/image-sequencer/node_modules/fast-glob/out/readers/stream.js: Unexpected token (16:10)
Warning: Error running grunt-browserify.� Use --force to continue.

npm ERR! code ELIFECYCLE
npm ERR! errno 6
npm ERR! image-sequencer@3.7.1 test-ui-2: `node ./node_modules/.bin/jest`
npm ERR! Exit status 6
npm ERR! 
npm ERR! Failed at the image-sequencer@3.7.1 test-ui-2 script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2022-01-15T18_20_05_943Z-debug.log
Error: Process completed with exit code 6.

Running "browserify:core" (browserify) task
>> Error: Parsing file /home/runner/work/image-sequencer/image-sequencer/node_modules/fast-glob/out/readers/stream.js: Unexpected token (16:10)
Warning: Error running grunt-browserify.� Use --force to continue.

Aborted due to warnings.
Error: Process completed with exit code 6.

Looks like an issue with browserify?

jywarren · 2022-01-15T18:43:15Z

Noting same error in Gitpod when running grunt build:

>> Error: Parsing file /workspace/image-sequencer/node_modules/fast-glob/out/readers/sync.js: Unexpected token (15:10)
Warning: Error running grunt-browserify. Use --force to continue.

jywarren · 2022-01-15T18:44:00Z

Odd, could we have changed browsify version while updating package-lock.json? Esp odd as we have updated package-lock.json regularly:

https://github.com/publiclab/image-sequencer/commits/main/package-lock.json

However we did regenerate it from scratch this time. Let's try reverting and updating just the relevant lines for the https/ssh issue.

jywarren · 2022-01-15T18:46:33Z

        "imgareaselect": "git+https://git@github.com/jywarren/imgareaselect.git#v1.0.0-rc.2",

    "node_modules/imgareaselect": {
      "version": "0.9.11-rc.1",
      "resolved": "git+https://git@github.com/jywarren/imgareaselect.git#db8ae869ca0fcb289252678cebd17d6f40711f61"
    },

    "imgareaselect": {
      "version": "git+https://git@github.com/jywarren/imgareaselect.git#db8ae869ca0fcb289252678cebd17d6f40711f61",
      "from": "imgareaselect@git+https://git@github.com/jywarren/imgareaselect.git#v1.0.0-rc.2"
    },

jywarren · 2022-01-15T19:04:00Z

https://github.com/publiclab/image-sequencer/releases/tag/v3.7.1

jywarren · 2022-01-15T19:29:05Z

bump to 3.7.1 and update release notes PR template

c6bbbf1

jywarren requested a review from a team as a code owner January 15, 2022 17:38

jywarren mentioned this pull request Jan 15, 2022

Checklist and coordination for v3.7.0 minor release #1751

Closed

11 tasks

update sw.js

ddf5c6b

jywarren requested a review from a team as a code owner January 15, 2022 17:39

attempted fix

11810c2

jywarren added 2 commits January 15, 2022 18:16

fix via npm/cli#2610 (comment)

804bf3f

repeated after removing package-lock.json

ea68f91

narrowed package-lock.json updates

21bb858

jywarren merged commit 79c948d into main Jan 15, 2022

bump to 3.7.1 w /dist/ files compiled, yarn.lock removed, updated release workflow issue template #2036

bump to 3.7.1 w /dist/ files compiled, yarn.lock removed, updated release workflow issue template #2036

Uh oh!

Conversation

jywarren commented Jan 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release notes

Added

Fixed

Changed

Uh oh!

gitpod-io bot commented Jan 15, 2022

Uh oh!

jywarren commented Jan 15, 2022

Uh oh!

jywarren commented Jan 15, 2022

Uh oh!

jywarren commented Jan 15, 2022

Uh oh!

jywarren commented Jan 15, 2022

Uh oh!

jywarren commented Jan 15, 2022

Uh oh!

jywarren commented Jan 15, 2022

Uh oh!

jywarren commented Jan 15, 2022

Uh oh!

jywarren commented Jan 15, 2022

Uh oh!

jywarren commented Jan 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jywarren commented Jan 15, 2022

Uh oh!

jywarren commented Jan 15, 2022

Uh oh!

jywarren commented Jan 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jywarren commented Jan 15, 2022 •

edited

Loading

jywarren commented Jan 15, 2022 •

edited

Loading