-
Notifications
You must be signed in to change notification settings - Fork 211
Bump ora from 5.4.1 to 6.1.2 #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bumps [ora](https://github.com/sindresorhus/ora) from 5.4.1 to 6.1.2. - [Release notes](https://github.com/sindresorhus/ora/releases) - [Commits](sindresorhus/ora@v5.4.1...v6.1.2) --- updated-dependencies: - dependency-name: ora dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
Whoa that was a fast update.... anyways here were my notes from the previous: Referencing sindresorhus/ora#181 Ora usages: Looks like the first one is more relevant maybe... more use of asynchronous? image-sequencer/src/cli/sequencerSteps.js Lines 72 to 87 in 3caa033
image-sequencer/src/cli/installModule.js Lines 11 to 15 in 3caa033
|
|
Yes, it now returns a promise instead of the spinner object: So now we need to change starting on line 74 here, to receive image-sequencer/src/cli/sequencerSteps.js Lines 72 to 87 in 3caa033
|
|
Oh you know what, the error is actually about the Maybe the promises stuff is not actually causing an issue... although we should check the spinner still stops properly. The change is instead probably:
|
Bumps ora from 5.4.1 to 6.1.2.
Release notes
Sourced from ora's releases.
Commits
702d1fe6.1.2f4e03eaRevert "Fix preserving stdin's pause state (#210)"1c24e0f6.1.177ccc1eFix preserving stdin's pause state (#210)c2400db6.1.06a4150aRefactor447812bExpose the spinnerintervalas a getterc5026b76.0.126ba606Upgrade dependencies83646646.0.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)