Skip to content

Comments

Bump publiclab-editor from 2.0.6 to 2.1.1#8285

Closed
dependabot-preview[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/publiclab-editor-2.1.1
Closed

Bump publiclab-editor from 2.0.6 to 2.1.1#8285
dependabot-preview[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/publiclab-editor-2.1.1

Conversation

@dependabot-preview
Copy link
Contributor

Bumps publiclab-editor from 2.0.6 to 2.1.1.

Release notes

Sourced from publiclab-editor's releases.

Editor revamp 2020 first release

Quoting @shreyaa-sharmaa in publiclab/PublicLab.Editor#555

Great work, team!

Over a month into GSoc and a month and half into Outreachy, we are ready to release a new version of PLE ❤️ These are some of the changes introduced:

Changes for users

  1. Remove File Button Added: #472 Now the image added in the main image module could be removed with just a click.
  2. Fix: Disabling of Markdown buttton on using shortcut keys #465 Earlier pressing CTRL+M disabled the Markdown button. Now, It has been fixed.
  3. A better UI with a toolbar that hovers only over the textarea (#522) and improved Choose file button (#462)

Additions

  1. Jest-puppeteer for UI testing by @shreyaa-sharmaa in #532 #541
  2. User workflow for documenting bugs by @Shulammite-Aso in #530
  3. Issue template chooser by @Shulammite-Aso in #474

Modifications/ Improvements

  1. Remove file button added by @NitinBhasneria in #472
  2. UI refinements: Stickiness of toolbar by @Shulammite-Aso in #522
  3. UI refinements: Choose file button UI improved by @NitinBhasneria in #462
  4. Nodejs version updated to 10 and 12 by @shreyaa-sharmaa in #554
  5. Fix: Disabling of Markdown buttton on using shortcut keys by @keshav234156 in #465

Amended v0.0.4 with corrected bower.json

No release notes provided.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [publiclab-editor](https://github.com/publiclab/PublicLab.Editor) from 2.0.6 to 2.1.1.
- [Release notes](https://github.com/publiclab/PublicLab.Editor/releases)
- [Commits](https://github.com/publiclab/PublicLab.Editor/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file JavaScript labels Aug 11, 2020
@gitpod-io
Copy link

gitpod-io bot commented Aug 11, 2020

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #8285 into main will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8285      +/-   ##
==========================================
- Coverage   81.44%   81.32%   -0.12%     
==========================================
  Files         101      101              
  Lines        5873     5873              
==========================================
- Hits         4783     4776       -7     
- Misses       1090     1097       +7     
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.24% <0.00%> (-3.83%) ⬇️

@jywarren
Copy link
Member

Hmm. @NitinBhasneria - i'm still seeing this:

ERROR["test_post_question_button_is_disabled_on_invalid_data", #<Minitest::Reporters::Suite:0x00007f3c82dccc40 @name="QuestionTest">, 185.50323760400002]
 test_post_question_button_is_disabled_on_invalid_data#QuestionTest (185.50s)
Minitest::UnexpectedError:         Capybara::ElementNotFound: Unable to find css ".wk-wysiwyg"
            test/system/post_question_test.rb:77:in `block in <class:QuestionTest>'
=[0811/151730.831497:WARNING:spdy_session.cc(3365)] Received HEADERS for invalid stream 93
[Screenshot]: tmp/screenshots/failures_test_posting_a_question.png
ERROR["test_posting_a_question", #<Minitest::Reporters::Suite:0x00007f3c7835e100 @name="QuestionTest">, 248.220782565]
 test_posting_a_question#QuestionTest (248.22s)
Minitest::UnexpectedError:         Capybara::ElementNotFound: Unable to find css ".wk-wysiwyg"
            test/system/post_question_test.rb:59:in `block in <class:QuestionTest>'
=[Screenshot]: tmp/screenshots/test_viewing_question_post.png
================[Screenshot]: tmp/screenshots/failures_test_posting_from_the_editor.png
ERROR["test_posting_from_the_editor", #<Minitest::Reporters::Suite:0x0000000008236150 @name="PostTest">, 374.757651075]
 test_posting_from_the_editor#PostTest (374.76s)
Minitest::UnexpectedError:         Capybara::ElementNotFound: Unable to find css ".wk-wysiwyg"
            test/system/post_test.rb:23:in `block in <class:PostTest>'

Did we forget something? @publiclab/editor

@NitinBhasneria
Copy link
Collaborator

Hmm. @NitinBhasneria - i'm still seeing this:

@jywarren Is our PR Added Image Input Condition #587 will be reflected in this version too(2.1.1) ?

@jywarren
Copy link
Member

Yes - but, we did not build the dist files... that must be it! Can you open a new one with dist files and v2.1.2?

@NitinBhasneria
Copy link
Collaborator

Yes - but, we did not build the dist files... that must be it! Can you open a new one with dist files and v2.1.2?

Just to be clear, I have to open a new PR in plots2 with Editor v2.1.2 and new dist files. Right?

@jywarren
Copy link
Member

Yes, that's right. Thank you!

@NitinBhasneria
Copy link
Collaborator

Yes, that's right. Thank you!

But still Bump Version from 2.1.1 to 2.1.2 PR is pending so yet the highest version is v2.1.1
And if we point to 2.1.2 in plots2 there will be an error in plots2 right?

@jywarren
Copy link
Member

It's OK, Dependabot will open a new one once we publish on NPM. I'll give it an extra bump at https://app.dependabot.com/accounts/publiclab to ensure it triggers quickly once we publish. Thanks!

@jywarren
Copy link
Member

Hi @NitinBhasneria can you link me to the relevant PRs? Thanks!

@NitinBhasneria
Copy link
Collaborator

Hi @NitinBhasneria can you link me to the relevant PRs? Thanks!

It's publiclab/PublicLab.Editor#587

@jywarren
Copy link
Member

Sorry @NitinBhasneria i'm just waiting for you to post the PR with the v2.1.2 version and the compiled dist files, thanks!

@jywarren
Copy link
Member

Maybe you've gone to sleep -- no worries! I'll open it!

@jywarren
Copy link
Member

OK! We'll resolve this in publiclab/PublicLab.Editor#590, after publishing that on NPM, dependabot should open a new PR and we should be OK!

@dependabot-preview
Copy link
Contributor Author

Superseded by #8286.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/publiclab-editor-2.1.1 branch August 11, 2020 18:46
@NitinBhasneria
Copy link
Collaborator

Sorry @NitinBhasneria i'm just waiting for you to post the PR with the v2.1.2 version and the compiled dist files, thanks!

Sorry, just misunderstood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file JavaScript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants