Add log level to KMP #386
Merged
Add log level to KMP #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-cebo
requested review from
jakub-grzesiowski,
jguz-pubnub,
kleewho and
parfeon
as code owners
In next commit logVerbosity should be removed from: commonMain/kotlin/com/pubnub/api/v2/PNConfiguration.kt and platform specific implementations
marcin-cebo
force-pushed
the
mc/addLogLevel_toKMP
branch
from
f1fd585 to
9d2e439
Compare
jguz-pubnub
reviewed
Dec 15, 2025
| val None = LogLevel(setOf(Level.NONE)) | ||
| actual val NONE = None | ||
|
|
||
| /** Only errors */ |
Contributor
There was a problem hiding this comment.
All the content below this comment isn't used anywhere.
Do we need to keep it? I would remove any additional code that's not accessed anywhere
Contributor
Author
There was a problem hiding this comment.
My understanding is that it could be used in the future if someone decide to debug Swift integrationTests in KMP e.g. by setting logLevel to e.g. "All"
jguz-pubnub
approved these changes
Dec 15, 2025
Contributor
Author
|
@pubnub-release-bot release kotlin as v12.0.3 |
1 similar comment
Contributor
Author
|
@pubnub-release-bot release kotlin as v12.0.3 |
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Internal changes - added logLevel for KMP tests