logging: include "mailnag" and default to WARNING level#228
Open
jdchristensen wants to merge 1 commit intopulb:masterfrom
Open
logging: include "mailnag" and default to WARNING level#228jdchristensen wants to merge 1 commit intopulb:masterfrom
jdchristensen wants to merge 1 commit intopulb:masterfrom
Conversation
Contributor
Author
|
Any feedback on this? Maybe this could be merged as is, and further improvements could be made in the future? |
|
Are you going to apply this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one way to address the questions raised in Issue #227. Let me know what you think. I'd also be inclined to remove the timestamp, and am happy to make that change as well if you'd like. One could also consider adding
-v/--verbosewhich triggers INFO level and--debugwhich triggers DEBUG level.Closes #227