[PULP-946] Implement PEP 658 #1031
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
multi-commit
jobselko
force-pushed
the
pep_658
branch
2 times, most recently
from
848fa89 to
31cd665
Compare
jobselko
force-pushed
the
pep_658
branch
6 times, most recently
from
5e4f2cb to
69e1326
Compare
gerrod3
requested changes
Dec 16, 2025
pulp_python/app/migrations/0019_create_missing_metadata_artifacts.py
Outdated
Show resolved
Hide resolved
pulp_python/app/migrations/0019_create_missing_metadata_artifacts.py
Outdated
Show resolved
Hide resolved
pulp_python/app/migrations/0019_create_missing_metadata_artifacts.py
Outdated
Show resolved
Hide resolved
jobselko
force-pushed
the
pep_658
branch
6 times, most recently
from
14bc63c to
0d693f8
Compare
jobselko
force-pushed
the
pep_658
branch
3 times, most recently
from
9950bbf to
ad11073
Compare
gerrod3
reviewed
Dec 19, 2025
Contributor
gerrod3
left a comment
gerrod3
left a comment
There was a problem hiding this comment.
The migration logic looks correct to me, just wondering what error messaging we should be doing.
pulp_python/app/migrations/0019_create_missing_metadata_artifacts.py
Outdated
Show resolved
Hide resolved
pulp_python/app/migrations/0019_create_missing_metadata_artifacts.py
Outdated
Show resolved
Hide resolved
pulp_python/app/migrations/0019_create_missing_metadata_artifacts.py
Outdated
Show resolved
Hide resolved
jobselko
commented
Dec 22, 2025
Comment on lines
+153
to
+162
| if result == "extraction_failed": | ||
| # Unset metadata_sha256 when metadata extraction fails | ||
| package.metadata_sha256 = None | ||
| packages_batch.append(package) | ||
| skipped_pkgs += 1 | ||
| continue | ||
| if result is None: | ||
| # Failed to build metadata artifact (init_and_validate failed) | ||
| skipped_pkgs += 1 | ||
| continue |
Contributor
Author
There was a problem hiding this comment.
If we also set package.metadata_sha256 = None if init_and_validate fails, all skipped packages will have the field nullified (None). Then the migration fixed everything because all PPC instances with the metadata_sha256 field set would have the artifact. (And we can maybe drop skipped_pkgs variable?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1047