Failed tasks no longer store traceback. #7065
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
reviewed
Nov 17, 2025
pulpcore/tasking/tasks.py
Outdated
Comment on lines
176
to
180
| raise ValueError("Immediate tasks must be async functions.") | ||
| raise NonAsyncImmediateTaskError(task_name=task.name) |
Member
There was a problem hiding this comment.
When this happens, it's a programming error. This should not be user visible.
aKlimau
force-pushed
the
no-traceback-exception
branch
from
7a4572d to
633d6be
Compare
aKlimau
force-pushed
the
no-traceback-exception
branch
from
633d6be to
43966ea
Compare
added 6 commits
November 19, 2025 14:43
aKlimau
force-pushed
the
no-traceback-exception
branch
6 times, most recently
from
ffcb19b to
0c2fc24
Compare
aKlimau
force-pushed
the
no-traceback-exception
branch
4 times, most recently
from
53afe18 to
0eec124
Compare
aKlimau
force-pushed
the
no-traceback-exception
branch
6 times, most recently
from
87c8b43 to
e7d65e1
Compare
aKlimau
force-pushed
the
no-traceback-exception
branch
from
e7d65e1 to
ba22c61
Compare
aKlimau
force-pushed
the
no-traceback-exception
branch
from
b5de7a3 to
cb4fe92
Compare
- Raise pulp-glue lower bound due to new imports requiring features from 0.30.0 - Add explicit pycares dependency to fix aiodns compatibility issue
aKlimau
force-pushed
the
no-traceback-exception
branch
from
673f40c to
f10b3ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed task tracebacks are currently a part of task model, it can expose sensitive information from an exception via the API. This change stops this behavior by only logging tracebacks and not storing them inside of tasks.
_execute_task and _aexecute_task are modified to log tracebacks for unknown exceptions but never save them to the Task record.
Task.set_failed() is updated to make the tb (traceback) argument optional.
A new PulpExceptionNoTraceback base class is added for known, user-facing errors (like a DNS failure) where the traceback is not useful and should not be logged.
A new DnsDomainNameException (inheriting from PulpExceptionNoTraceback) is added to handle DNS lookup failures (e.g., bad remote URLs) as a known user error.