deps: Update whats-my-line to bump dugite to 2.1.0
#36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Summary
This switches
whats-my-lineto Pulsar's fork, via github.com tarball URL off of the fork repo, but a non-masterbranch to specifically pull in thedugiteversion bump/pin to 2.1.0, matching the version that's pinned here.Why? To dedupe
dugitein core repo, which is a pretty hefty ~35.5 MB dependency (on macOS, at least).Changes
pulsar-editorg made in thewhats-my-lineforkContains (effectively) the following
whats-my-linePRs over at our fork:package.jsonversion whats-my-line#2dugiteto2.1.0whats-my-line#7 (pending PR, at the time I'm writing this, but cherry-picked onto a custom branch to exclude the following PRs:)Does not include the following
whats-my-linePRs:https://github.com/pulsar-edit/whats-my-line/pull/5https://github.com/pulsar-edit/whats-my-line/pull/6Those changes can wait until the
superstringupdate efforts are more set in stone, synced across all relevant repos, and tested properly (ended up being a bigger project than thedugitestuff.)Context
Updating from a non-
masterbranch commit ofwhats-my-linerepo for now, to get thedugiteversion syncing/deduping effort landed in core repo sooner, since thesuperstringstuff is taking longer than thedugitestuff.(The commit from
whats-my-linerepo used in this PR is https://github.com/pulsar-edit/whats-my-line/tree/348e8d10d9b9a1fd717cd4cc1263297844732768, AKA https://github.com/pulsar-edit/whats-my-line/tree/just-the-dugite-2.1.0-bump.)There's no sense delaying the
dugitestuff just to do thesuperstringstuff together at the same (potentially much later) time. Better to get each done "right" and land each when it's ready, IMO.So here's this. No
superstringbumps, just pinningdugiteto 2.1.0Meta Stuff: PR Coordination at this Repo
This is kind of an alternative to/subset of #35 to get the
dugitestuff shipped faster, since it's ready and Regular release day for the Pulsar editor is coming soon, and the the wholesuperstring,keytar,win-iconvshenanigans is still ongoing at the time I'm writing this, delaying the completion of #35 and related efforts.I would intend to just re-work the
whats-my-lineupdate in that PR (just by rebasing over top of this PR) if this PR merges first.