Update docs for enum and utility type support#17552
Conversation
|
Your site preview for commit f55344c is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17552-f55344c2.s3-website.us-west-2.amazonaws.com. |
f55344c to
2619df6
Compare
|
Your site preview for commit 2619df6 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17552-2619df63.s3-website.us-west-2.amazonaws.com. |
Documentation ReviewI've reviewed the changes to document enum and utility type support. The additions are accurate and well-structured. Here are a few minor suggestions for improvement: Issues FoundLine 147-148: Code block formatting The TypeScript code examples use inline comments. Consider adding a brief introductory sentence before each code block to improve readability, especially for readers who may scan the page. Line 160-163: Python enum example The Python example uses uppercase enum member names ( Or alternatively, use snake_case values to match Python conventions: Line 170: Utility types wording The utility types section is quite brief. Consider adding a short example to match the pattern established by the enum section, or at minimum add a brief explanation of what these utility types do. Positive Notes
Overall AssessmentThe changes accurately document the new enum and utility type support. The additions fit well into the existing document structure and follow the style guide for code blocks and headings. If you'd like me to review additional changes or provide more detailed suggestions, please mention @claude in a comment. |
|
@claude no |
|
Claude finished @julienp's task in 14s —— View job Documentation ReviewI've reviewed the changes to document enum and utility type support. The additions are accurate and well-structured. The author has declined the suggested improvements from my initial review. The documentation changes are ready as-is. |
Python has supported enums for a while. TS will as of next week's release. TS will also support
Partial<T>andRequired<T>.