Skip to content

Update docs for enum and utility type support#17552

Open
julienp wants to merge 1 commit intomasterfrom
julienp/emuemu
Open

Update docs for enum and utility type support#17552
julienp wants to merge 1 commit intomasterfrom
julienp/emuemu

Conversation

@julienp
Copy link
Contributor

@julienp julienp commented Feb 12, 2026

Python has supported enums for a while. TS will as of next week's release. TS will also support Partial<T> and Required<T>.

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@julienp julienp marked this pull request as ready for review February 12, 2026 16:09
@claude
Copy link
Contributor

claude bot commented Feb 12, 2026

Documentation Review

I've reviewed the changes to document enum and utility type support. The additions are accurate and well-structured. Here are a few minor suggestions for improvement:

Issues Found

Line 147-148: Code block formatting

The TypeScript code examples use inline comments. Consider adding a brief introductory sentence before each code block to improve readability, especially for readers who may scan the page.

Line 160-163: Python enum example

The Python example uses uppercase enum member names (VALUE1, VALUE2) while the TypeScript example uses PascalCase (Value1, Value2). For consistency with the actual string values used, consider matching the casing:

  class MyEnum(Enum):
      VALUE_1 = "Value1"
      VALUE_2 = "Value2"

Or alternatively, use snake_case values to match Python conventions:

  class MyEnum(Enum):
      value_1 = "value_1"
      value_2 = "value_2"

Line 170: Utility types wording

The utility types section is quite brief. Consider adding a short example to match the pattern established by the enum section, or at minimum add a brief explanation of what these utility types do.

Positive Notes

  • Clear section headers that match the existing structure
  • Good use of language-specific subsections
  • Examples are syntactically correct
  • The placement within the "Supported types" section is appropriate

Overall Assessment

The changes accurately document the new enum and utility type support. The additions fit well into the existing document structure and follow the style guide for code blocks and headings.


If you'd like me to review additional changes or provide more detailed suggestions, please mention @claude in a comment.

@julienp
Copy link
Contributor Author

julienp commented Feb 12, 2026

@claude no

@julienp julienp requested a review from jkodroff February 12, 2026 17:34
@claude
Copy link
Contributor

claude bot commented Feb 12, 2026

Claude finished @julienp's task in 14s —— View job


Documentation Review

I've reviewed the changes to document enum and utility type support. The additions are accurate and well-structured.

The author has declined the suggested improvements from my initial review. The documentation changes are ready as-is.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants