Open
Conversation
Contributor
borisschlosser
left a comment
borisschlosser
left a comment
There was a problem hiding this comment.
lgtm! Still asking others who are more familiar with the code to approve.
These changes add a new node type, DocumentNode, to the syntax package. This node allows concrete syntaxes to attach document-level syntactical trivia (e.g. comments, metadata, etc.) that is not otherwise associated with a node. These changes also replace `*RotationResult` with `RotationResult`, as the result is already nilable. This fixes an issue when running the eval tests with `PULUMI_ACCEPT` set. Fixes #260.
Co-authored-by: Boris Schlosser <schlosser.boris@gmail.com>
pgavlin
force-pushed
the
pgavlin/document-syntax
branch
from
6f14e52 to
fa8ef86
Compare
nyobe
approved these changes
Apr 30, 2025
Member
Author
|
So I haven't merged this yet because I'm not totally sure that it's the right approach. Part of me feels like this is shoehorning a YAML concept into the generic syntax layer, and that a better approach would be to somehow capture this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes add a new node type, DocumentNode, to the syntax package. This node allows concrete syntaxes to attach document-level syntactical trivia (e.g. comments, metadata, etc.) that is not otherwise associated with a node.
These changes also replace
*RotationResultwithRotationResult, as the result is already nilable. This fixes an issue when running the eval tests withPULUMI_ACCEPTset.Fixes #260.