cli: warn on ambiguous 2-part environment refs

[LouisLau-art]

Fixes #613.

When a user belongs to an org named a, a 2-part env reference like a/b can be interpreted as either:

• <project>/<environment> (default org + project a + env b), or
• <org>/default/<environment> (org a + default project + env b).

This adds a warning in that case, recommending the unambiguous 3-part form <org>/<project>/<environment>.

Tests:

• go test ./cmd/esc/cli -run TestCLI

[seanyeh]

thanks for contributing! I have a few small comments

[seanyeh]

let's not do any org checking in this method - we already do this elsewhere (look at the other comments)
This method can simply print out a warning

[seanyeh]

I don't think this is necessary

[seanyeh]

we do the org-checking below - you can move this call to inside the if existsLegacyPath { ... } check

[seanyeh]

create a new check after we calculate existsLegacyPath below, and move this call there. something like:

if existsLegacyPath {
  cmd.warnIfAmbiguousTwoPartRef(...)
}

[seanyeh]

thanks for adding a test!

[LouisLau-art]

Thanks for the detailed review comments. I’ll push a follow-up that:

1. removes org checking from the warning helper,
2. moves the warning call under the existsLegacyPath branch (after it is computed),
3. drops the unnecessary piece you called out and keeps the test update.

I’ll post again after the patch is up.

[LouisLau-art]

Pushed follow-up commit 5927edc with the requested changes:

1. warnIfAmbiguousTwoPartRef now only prints the warning message (no org membership checks).
2. Warning calls were moved to run only after existsLegacyPath is determined:
   • getNewEnvRef: warn inside if existsLegacyPath { ... }
   • getExistingEnvRefWithRelative: warn inside if existsLegacyPath { ... }
3. Removed the warning de-dup map from envCommand.

Test updates:

• testPulumiClient.EnvironmentExists now checks the in-memory environment map.
• Updated env-ambiguous-two-part-warning.yaml to model the legacy-path resolution case.

Validation:

• go test ./cmd/esc/cli -run TestCLI -count=1

[seanyeh]

one last comment: we already have the same check below (see line 306) - let's move this warning there

[LouisLau-art]

Thanks for the final note — agreed. I’ll move that warning to the shared check so we only emit it once and avoid duplicate logic.

[LouisLau-art]

Clarification: I’ll move the warning call under the shared existsLegacyPath check so the warning is emitted once from a single place.