Verification if there is space above the menu item selected#15
Open
Neymello wants to merge 1 commit intopupunzi:masterfrom
Open
Verification if there is space above the menu item selected#15Neymello wants to merge 1 commit intopupunzi:masterfrom
Neymello wants to merge 1 commit intopupunzi:masterfrom
Conversation
The verification if there is space above the menu item select should be done only when the menu option openOnRight is true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verification if there is space above the menu item selected should be done only when the menu option openOnRight is true.
Before this change, the submenu is showed on top of the menu when there is space above the menu and this space can fit the submenu.