Open
Conversation
* Adds a way to declare types that can be logged directly to the console. (Ex: Error with stacktraces)
Contributor
|
The problem with this is that it's quite JS-specific, and for such a low-down library in the ecosystem I think we need to make sure that what we provide here makes sense in alternate backends, and I doubt this will. Plus, I don't think a type class is appropriate here, because pretty much any value can be displayed at least half-sensibly in a JS console if you just pass it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS console functions typically handle logging of certain types in a special manner. For instance, logging Errors also display an accompanying stack trace. Logging dom elements on browsers can also emits a dom tree that can be interactively inspected.
Pointing to purescript-debug might not always suffice, since there are use cases outside of debugging -- for instance logging errors with stack traces on server side purescript.
I've read that there used to be
Anyvariants (logAny,warnAny) that wereforall a. a -> Effect Unit, but have been removed.Perhaps aa middleground between accepting anything vs limiting logging only to strings is to simply mark which types make sense to be logged. So I introduced the typeclass
IsLoghere and an instance for String and Array. I'm open to renaming this. (Logging extra long arrays auto truncates the array and offers interactive expanding on browsers)Another option is to keep
logonly for strings, but introducelog'which accepts others that have anIsLoginstance.