Add oneOf1 and oneOfMap1 to Data.Semigroup.Foldable#122
Open
kl0tl wants to merge 1 commit intopurescript:masterfrom
Open
Add oneOf1 and oneOfMap1 to Data.Semigroup.Foldable#122kl0tl wants to merge 1 commit intopurescript:masterfrom
kl0tl wants to merge 1 commit intopurescript:masterfrom
Conversation
kl0tl
force-pushed
the
oneOf1-and-oneOfMap1
branch
from
6e84c1d to
3c8fd65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In purescript/purescript-control#63 we‘re considering to merge
PlusintoAlternativeand then remove the illegal instance of Plus for Aff, Plus and Alternative for ParAff and add an Alt instance for Effect.As noted by @natefaubion in purescript/purescript-control#63 (comment), this would prevent Control.Parallel.parOneOf and Control.Parallel.parOneOfMap to work with Aff, but we could rewrite those combinators in terms of oneOf1 and oneOfMap1.