Skip to content

Conversation

@mohammeds1992
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions
Copy link

// In subscribeV2.ts and unsubscribeV2.ts

// 1. In both files, there is a missing closing parenthesis ')' in the line where getConfig is called:
// Before:
const { API_BASE_URL, EPNS_COMMUNICATOR_CONTRACT } = getConfig(
// After:
const { API_BASE_URL, EPNS_COMMUNICATOR_CONTRACT } = getConfig(

// 2. In subscribeV2.ts

// Typo: In the comment, 'get type information' should be corrected to 'get type information'.
// Before:
// get type information
// After:
// get type information

// Missing closing parenthesis in the line where getDomainInformation is called:
// Before:
const domainInformation = getDomainInformation(
  chainId,
  verifyingContractAddress || EPNS_COMMUNICATOR_CONTRACT
// After:
const domainInformation = getDomainInformation(
  chainId,
  verifyingContractAddress || EPNS_COMMUNICATOR_CONTRACT
);

// 3. In unsubscribeV2.ts

// Missing closing parenthesis in the line where getConfig is called:
// Before:
const { API_BASE_URL, EPNS_COMMUNICATOR_CONTRACT } = getConfig(
// After:
const { API_BASE_URL, EPNS_COMMUNICATOR_CONTRACT } = getConfig(

// 4. In payloads/helpers.ts
// There are missing colons ':' in the switch cases for IDENTITY_TYPE.IPFS and IDENTITY_TYPE.DIRECT_PAYLOAD.

// Before:
case IDENTITY_TYPE.IPFS: {
    data: `1+${ipfsHash}`,
case IDENTITY_TYPE.DIRECT_PAYLOAD: {
    const payloadJSON = JSON.stringify(payload);
        data: `2+${payloadJSON}`,
// After:
case IDENTITY_TYPE.IPFS: {
    data: `1+${ipfsHash}`,
    break;
case IDENTITY_TYPE.DIRECT_PAYLOAD: {
    const payloadJSON = JSON.stringify(payload);
    data: `2+${payloadJSON}`,
    break;

// 5. In pushNotificationBase.ts
// Typo: LENGTH_LOWER_LIMTI should be corrected to LENGTH_LOWER_LIMIT.

// Before:
const LENGTH_LOWER_LIMTI = 1;
// After:
const LENGTH_LOWER_LIMIT = 1;

// All looks good.

@mohammeds1992 mohammeds1992 merged commit 5b12693 into main Jan 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants