Skip to content

Conversation

@mohammeds1992
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions
Copy link

In the code provided, I found the following issues:

  1. In the getChannels.ts file:

    • Typo in the import statement for CONSTANTS, it should be imported as CONSTANTS but it's imported as CONSTANTS.
    • Typo in the Error message in the catch block, there are extra - symbols.
    • The catch block throws an error but doesn't propagate it, so no need to catch there, just let the error propagate for better handling upstream.
  2. In the search.ts file:

    • Typo in the import statement for Constants, it should be imported as CONSTANTS but it's imported as Constants.
    • Typo in the spelling of NotificationType in the ChannelFeedsOptions.
    • Missing closing braces in the search function. There is an unclosed brace at the end of the file.
  3. In the PushNotificationTypes.ts file:

    • Typo in the spelling of NotificationType in the ChannelFeedsOptions.
  4. In the channel.ts file:

    • The search function has a missing catch block after the axios call, which should handle errors.
    • Typo in the spelling of channel in the list function, it should be channel but it's written as channell.

Apart from the specified issues, everything else looks good in the provided code snippets.

Kindly review and correct the mentioned issues.

@mohammeds1992 mohammeds1992 merged commit 1710123 into main Feb 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants