Refactor: Replace install/update alerts with a welcome page #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I replaced the disruptive `alert()` dialogs on new installs and updates with a dedicated `welcome.html` page that opens in a new tab. This provides a cleaner and more friendly experience for you. - I created `welcome.html` and `welcome.js` to handle the new user flow. - I modified `popup.js` to open the welcome page instead of showing alerts. - I updated `popup.html` with a more appropriate message. - I added navigation links to the new welcome page in `options.html` and `userguide.html`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the disruptive
alert()dialogs on new installs and updates with a dedicatedwelcome.htmlpage that opens in a new tab. This provides a cleaner and more friendly experience for you.welcome.htmlandwelcome.jsto handle the new user flow.popup.jsto open the welcome page instead of showing alerts.popup.htmlwith a more appropriate message.options.htmlanduserguide.html.