fix: type for filepath in main hash function #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwlmc
previously approved these changes
Nov 23, 2025
Owner
pwlmc
left a comment
pwlmc
left a comment
There was a problem hiding this comment.
lgtm
@badrequest400 thanks for the contribution, much appreciated!
Can I ask you to:
- Sync with
pwlmc:master(we should get the CI run on this PR after you rebase) - Exclude
package-lock.jsonchanges from the PR. You likely haveauto-install-peersenabled for your NPM, which is ok, but I don't want to force auto-peer install by default in the project.
badrequest400
force-pushed
the
fix/types
branch
from
7a901d8 to
0160f85
Compare
Contributor
Author
Hey @pwlmc Thanks for the review and considering it. I've excluded the peer changes and rebased the branch. Hope this will be okay now. Let me know! |
Owner
|
@badrequest400 I will release the new version this weekend |
Contributor
Author
Thanks so much for looking at this @pwlmc 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
hash()function is meant to take either a string filepath or aBufferas parameter. Currently this is not typed correctly and theBufferbranch cannot be used in Typescript without errors.Solution
Add
Bufferto type union for the parameter.closes #338