Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables TypeScript type-checking for test files and adds V8-based code coverage support to the imghash package.
- Removed test file exclusions from
tsconfig.jsonto enable TypeScript type-checking of test files - Added
@vitest/coverage-v8dependency for V8-based coverage reporting - Updated package-lock.json with all necessary transitive dependencies
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/imghash/tsconfig.json | Removed **/*.spec.ts and **/*.test.ts from exclude array to enable type-checking of test files |
| packages/imghash/package.json | Added @vitest/coverage-v8@^4.0.14 as a development dependency |
| package-lock.json | Added coverage-v8 and related dependencies (babel, istanbul libs, magicast, obug, etc.) and updated vitest-related packages to 4.0.14 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vitest/coverage-v8as a development dependency inpackage.jsonto enable V8-based code coverage reporting for tests.tsconfig.jsonto no longer explicitly exclude test files (*.spec.ts,*.test.ts)