Skip to content

fix: typecheck and add v8 coverage#345

Merged
pwlmc merged 1 commit intomasterfrom
pwlmc/fix-typecheck-and-add-v8-coverage
Nov 29, 2025
Merged

fix: typecheck and add v8 coverage#345
pwlmc merged 1 commit intomasterfrom
pwlmc/fix-typecheck-and-add-v8-coverage

Conversation

@pwlmc
Copy link
Owner

@pwlmc pwlmc commented Nov 29, 2025

  • Added @vitest/coverage-v8 as a development dependency in package.json to enable V8-based code coverage reporting for tests.
  • Updated tsconfig.json to no longer explicitly exclude test files (*.spec.ts, *.test.ts)

Copilot AI review requested due to automatic review settings November 29, 2025 11:52
@pwlmc pwlmc merged commit ca49fde into master Nov 29, 2025
11 checks passed
@pwlmc pwlmc deleted the pwlmc/fix-typecheck-and-add-v8-coverage branch November 29, 2025 11:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables TypeScript type-checking for test files and adds V8-based code coverage support to the imghash package.

  • Removed test file exclusions from tsconfig.json to enable TypeScript type-checking of test files
  • Added @vitest/coverage-v8 dependency for V8-based coverage reporting
  • Updated package-lock.json with all necessary transitive dependencies

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
packages/imghash/tsconfig.json Removed **/*.spec.ts and **/*.test.ts from exclude array to enable type-checking of test files
packages/imghash/package.json Added @vitest/coverage-v8@^4.0.14 as a development dependency
package-lock.json Added coverage-v8 and related dependencies (babel, istanbul libs, magicast, obug, etc.) and updated vitest-related packages to 4.0.14

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant