Added Cryptography Modules #58
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ["/challenge/run.py"], | ||
| stdout=subprocess.PIPE, | ||
| text=True, | ||
| ) | ||
| assert "TASK:" in p.stdout.readline() |
There was a problem hiding this comment.
The aes-cbc public test asserts the first line from /challenge/run.py contains "TASK:", but the template used by that run script (common/crypto_aes_cbc_simple.py.j2) prints only the AES key and ciphertext headers, never a TASK prefix. As written the assertion will always fail on the very first read, so the challenge can't pass its own public tests.
Useful? React with 👍 / 👎.
| proc = subprocess.Popen( | ||
| ["/challenge/crypto.py"], | ||
| stdin=subprocess.PIPE, | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE, |
There was a problem hiding this comment.
Multiple public tests (sha, sha2, tls, rsa3, rsa4) spawn /challenge/crypto.py, but each challenge only ships a run.py generated from crypto_levels.py.j2, so subprocess.Popen will hit ENOENT before any challenge logic runs. Either the tests need to call run.py or the build needs to install the binary under the expected name; in the current commit these tests cannot succeed because the referenced executable is absent.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Oh shoot, I must have made this typo while copy pasting stuff between files.
1 participant
Added all the cryptography challenges to the monorepo and added the public tests as well