fixing unnecessary import of ProductTree #162
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix a failing import by commenting out the ProductTree import from sage.rings.generic. However, ProductTree is actually used in the code on line 428 within the KummerLineIsogeny_VeluSqrt._hI_precomputation method. While the challenge code doesn't trigger this code path due to using small primes (< 587) with a default threshold of 1500, commenting out the import will break the VéluSqrt functionality and cause a NameError if that code path is ever executed.
Key Changes
- Commented out the import statement for
ProductTreefromsage.rings.generic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line
from sage.rings.generic import ProductTreein montgomery_isogenies/kummer_isogeny.py fails but is not necessary.Fixes #144