Fix: Support rowspans breaking over page jumps (#1460) #1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neyhlo
changed the title
andersonhc
requested changes
Dec 18, 2025
Collaborator
andersonhc
left a comment
andersonhc
left a comment
There was a problem hiding this comment.
Can you please add some tests for your feature?
/test/table/test_table.py should be the best place for it - and you can use the current tests there as inspiration
Comment on lines
+253
to
+264
| # Modification pour issue #1460 : On autorise le dépassement de page | ||
| # if ( | ||
| # page_break | ||
| # and self._fpdf.y + pagebreak_height > self._fpdf.page_break_trigger | ||
| # ): | ||
| # # Restoring original position on page: | ||
| # self._fpdf.x = prev_x | ||
| # self._fpdf.y = prev_y | ||
| # self._fpdf.l_margin = prev_l_margin | ||
| # raise ValueError( | ||
| # f"The row with index {i} is too high and cannot be rendered on a single page" | ||
| # ) |
Collaborator
There was a problem hiding this comment.
Please delete the commented code block
We don't keep dead code in the repository - git history is good enough if we ever need to recover old code
|
|
||
| # Continue to the next cell | ||
| continue | ||
| # --- END MODIFICATION --- |
Collaborator
There was a problem hiding this comment.
Please remove # --- START MODIFICATION / END MODIFICATION comments
Reserve comments for pieces of code you believe are complicated enough to warrant the additional information
Member
|
Hi @Neyhlo Without any answer from you, we will soon close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1460 ---
What changes are being made?
This PR fixes a bug where tables containing large vertically spanned cells (
rowspan) would crash when exceeding the page height, and allows them to break across pages cleanly.Key changes:
ValueErrorcheck inTable.render()that prevented long rows from rendering is removed._get_span_origin) and logic in_render_table_rowto draw the vertical borders for spanned cells on continuation pages (the "ghost borders").Checklist:
A unit test is covering the code added / modified by this PR
(Note: We verified this by running existing
rowspantests which fail without the fix.)In case of a new feature, docstrings have been added, with also some documentation in the
docs/folder (N/A, this is a bug fix/enhancement to existing feature)This PR is ready to be merged
Additional comments:
The change in functionality requires updating several golden PDF files in the test suite. Specifically, tests in
test_table_rowspan.pyandtest_table_padding.pyfail because the visual output now includes the vertical borders on continuation pages, which changes the MD5 hash.The reference files (golden files) need to be updated to match the new, correct behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.