fix: correct bugs in expense_analysis example#152
Open
Hupperich-Manuel wants to merge 1 commit intopydantic:mainfrom
Open
fix: correct bugs in expense_analysis example#152Hupperich-Manuel wants to merge 1 commit intopydantic:mainfrom
Hupperich-Manuel wants to merge 1 commit intopydantic:mainfrom
Conversation
- Fix get_expenses return key from 'items' to 'expenses' to match consumer expectation - Fix get_custom_budget to actually return the budget data instead of discarding it
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two bugs in
examples/expense_analysis/data.pythat prevented the example from running correctly.Bug Fixes
1.
get_expenses()- Wrong dictionary keyreturn {..., 'items': items}return {..., 'expenses': items}main.pyline 56 callsexpenses_data.get("expenses", []), so the key must be"expenses"not"items"2.
get_custom_budget()- Missing return statementcustom_budgets.get(user_id)(result was discarded)NoneTesting
Ran
python examples/expense_analysis/main.pyand confirmed it now produces correct output:{'total_team_members_analyzed': 5, 'count_exceeded_budget': 1, 'over_budget_details': [{'name': 'Carol Jones', 'total_spent': 6740.0, 'budget': 5000, 'amount_over': 1740.0}]}