add aarch64-unknown-linux-gnu (linux-arm64) JS binding target#154
Open
Bl3f wants to merge 1 commit intopydantic:mainfrom
Open
add aarch64-unknown-linux-gnu (linux-arm64) JS binding target#154Bl3f wants to merge 1 commit intopydantic:mainfrom
aarch64-unknown-linux-gnu (linux-arm64) JS binding target#154Bl3f wants to merge 1 commit intopydantic:mainfrom
Conversation
Docker on Apple Silicon runs linux/arm64, but the native binding `@pydantic/monty-linux-arm64-gnu` was never built or published. - Add `aarch64-unknown-linux-gnu` to napi targets in package.json - Add CI build job using `ubuntu-24.04-arm` native ARM runner - Add target to the Linux JS binding test matrix Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aarch64-unknown-linux-gnuto the napi targets inpackage.jsonso the@pydantic/monty-linux-arm64-gnuoptional dependency is generatedubuntu-24.04-armARM runnerruns-onexpression and docker params already handle aarch64 correctly)Motivation
Docker on Apple Silicon (and any linux/arm64 environment) fails to load
@pydantic/montybecause the native binding foraarch64-unknown-linux-gnuis never built or published (related to #153):Reproduction: