Conversation
friendlymatthew
force-pushed
the
get_attr
branch
from
f181b91 to
74cf03b
Compare
Comment on lines
+30
to
+52
| let (mut positional, kwargs) = args.into_parts(); | ||
|
|
||
| let pos_count = positional.len(); | ||
| let kw_count = kwargs.len(); | ||
|
|
||
| // Check for unsupported kwargs | ||
| if !kwargs.is_empty() { | ||
| for (k, v) in kwargs { | ||
| k.drop_with_heap(heap); | ||
| v.drop_with_heap(heap); | ||
| } | ||
| for v in positional { | ||
| v.drop_with_heap(heap); | ||
| } | ||
| return Err(ExcType::type_error_arg_count("getattr", 2, pos_count + kw_count)); | ||
| } | ||
|
|
||
| if !(2..=3).contains(&pos_count) { | ||
| for v in positional { | ||
| v.drop_with_heap(heap); | ||
| } | ||
| return Err(ExcType::type_error_arg_count("getattr", 2, pos_count)); | ||
| } |
Member
There was a problem hiding this comment.
if we don't already have it, we should have and use a method on ArgValues to get 2 or 3 args, and use that.
Member
There was a problem hiding this comment.
you need gets for getting from a module.
Comment on lines
+38
to
+48
| try: | ||
| getattr(s, 123) | ||
| assert False, 'getattr() with non-string name should raise TypeError' | ||
| except TypeError as e: | ||
| assert 'attribute name must be string' in str(e), 'Error message should mention string requirement' | ||
|
|
||
| try: | ||
| getattr(s, None) | ||
| assert False, 'getattr() with None name should raise TypeError' | ||
| except TypeError: | ||
| pass |
Member
There was a problem hiding this comment.
always do an exact check on the message from TypeError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
getattr(object, name[, default])builtin function. For a given object, it returns the attribute value if it exists, the provided default value if the attribute doesn't exist and a default is given, or raisesAttributeErrorotherwise