Implement del statement for subscript deletion#68
Open
friendlymatthew wants to merge 1 commit intomainfrom
Open
Implement del statement for subscript deletion#68friendlymatthew wants to merge 1 commit intomainfrom
del statement for subscript deletion#68friendlymatthew wants to merge 1 commit intomainfrom
Conversation
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
66ff161 to
d05cac5
Compare
friendlymatthew
commented
Jan 23, 2026
Comment on lines
+190
to
+191
| let mask = index >> 63; | ||
| let normalized_index = index + (mask & len); |
Member
Author
There was a problem hiding this comment.
This is a very harmless and branchless way of doing:
let normalized_index = if index < 0 { index + len } else { index };The idea being:
- if index < 0, then mask is -1 (all bits set)
- if index >= 0, mask = 0, so we add 0
f290615 to
3f227be
Compare
3f227be to
2a21db6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
delstatement on subscripted objects, which enable deletion of list elements and dict entries through thedel foo['bar']syntax