-
Notifications
You must be signed in to change notification settings - Fork 1
apply cookiecutter #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
apply cookiecutter #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the project to apply the latest cookiecutter template and align various project settings. Key changes include:
- Adding Python 3.13 in the classifiers and updating version information in pyproject.toml.
- Modifying the documentation configuration (docs/conf.py) to add a file download utility for gallery images and adjust header dropdown behavior.
- Introducing and updating GitHub workflow files to enforce version milestones and label presence, as well as a minor update to the issue template.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added Python 3.13 classifier and adjusted version bump settings. |
| docs/conf.py | Added numpy import, introduced a file download function, and refined header processing. |
| .github/workflows/has_version_milestone.yml | New workflow to ensure pull requests have a version milestone. |
| .github/workflows/has_label.yml | Updated workflow to check for label presence on pull requests. |
| .github/ISSUE_TEMPLATE.md | Updated text to reference "sofar" instead of "pyfar". |
Comments suppressed due to low confidence (2)
docs/conf.py:190
- [nitpick] Consider using Python's built-in sum() function instead of numpy.sum() to count booleans. This change would reduce external dependency overhead while achieving the same result.
count_gallery_headings = np.sum(['https://pyfar-gallery.readthedocs.io' in line for line in lines])
.github/workflows/has_label.yml:22
- The updated label check only verifies that some label exists instead of enforcing a version label format. Confirm if this change is intended or if it may affect version label validation.
if [ -z "$LABEL_NAMES" ]; then
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
6 tasks
hoyer-a
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
apply latest cookiecuuter,
See pyfar/pyfar#789