Skip to content

Conversation

@ahms5
Copy link
Member

@ahms5 ahms5 commented Apr 23, 2025

Which issue(s) are closed by this pull request?

apply latest cookiecuuter,
See pyfar/pyfar#789

@ahms5 ahms5 requested a review from Copilot April 23, 2025 18:06
@ahms5 ahms5 self-assigned this Apr 23, 2025
@ahms5 ahms5 added the documentation Improvements or additions to documentation label Apr 23, 2025
@ahms5 ahms5 moved this from Backlog to Require review in Weekly Planning Apr 23, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the project to apply the latest cookiecutter template and align various project settings. Key changes include:

  • Adding Python 3.13 in the classifiers and updating version information in pyproject.toml.
  • Modifying the documentation configuration (docs/conf.py) to add a file download utility for gallery images and adjust header dropdown behavior.
  • Introducing and updating GitHub workflow files to enforce version milestones and label presence, as well as a minor update to the issue template.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Added Python 3.13 classifier and adjusted version bump settings.
docs/conf.py Added numpy import, introduced a file download function, and refined header processing.
.github/workflows/has_version_milestone.yml New workflow to ensure pull requests have a version milestone.
.github/workflows/has_label.yml Updated workflow to check for label presence on pull requests.
.github/ISSUE_TEMPLATE.md Updated text to reference "sofar" instead of "pyfar".
Comments suppressed due to low confidence (2)

docs/conf.py:190

  • [nitpick] Consider using Python's built-in sum() function instead of numpy.sum() to count booleans. This change would reduce external dependency overhead while achieving the same result.
count_gallery_headings = np.sum(['https://pyfar-gallery.readthedocs.io' in line for line in lines])

.github/workflows/has_label.yml:22

  • The updated label check only verifies that some label exists instead of enforcing a version label format. Confirm if this change is intended or if it may affect version label validation.
if [ -z "$LABEL_NAMES" ]; then

@ahms5 ahms5 added this to the v1.2.2 milestone Apr 23, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Require review to Reviewer Approved in Weekly Planning Apr 24, 2025
@ahms5 ahms5 moved this from Reviewer Approved to Require review in Weekly Planning Apr 24, 2025
@f-brinkmann f-brinkmann modified the milestones: v1.2.2, v1.3.0 Apr 25, 2025
@f-brinkmann f-brinkmann merged commit 84a1f5e into main Apr 25, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from Require review to Done in Weekly Planning Apr 25, 2025
@f-brinkmann f-brinkmann deleted the cookiecutter branch April 25, 2025 07:46
@f-brinkmann f-brinkmann modified the milestones: v1.3.0, v1.2.2 May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants