Skip to content

Conversation

@ahms5
Copy link
Member

@ahms5 ahms5 commented May 8, 2025

Which issue(s) are closed by this pull request?

Closes #126

Changes proposed in this pull request:

  • It adds packaging to dependencies, which got lost when we switched to pyproject.toml.
  • Apparently, it is installed by default with conda, so we did not notice it before.
  • I checked for other missing packages, but found nothing

@ahms5 ahms5 added this to the v1.2.2 milestone May 8, 2025
@ahms5 ahms5 moved this from Backlog to Require review in Weekly Planning May 8, 2025
@ahms5 ahms5 added the hot label May 8, 2025
@ahms5 ahms5 self-assigned this May 8, 2025
@ahms5 ahms5 requested a review from Copilot May 8, 2025 15:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds the "packaging" dependency to the project's dependency list in pyproject.toml, addressing an oversight from the switch to pyproject.toml.

  • Packaging dependency added to ensure compatibility.
  • No other missing packages were found.

@github-project-automation github-project-automation bot moved this from Require review to Reviewer Approved in Weekly Planning May 9, 2025
@f-brinkmann f-brinkmann merged commit a6ac28b into main May 9, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in Weekly Planning May 9, 2025
@f-brinkmann f-brinkmann deleted the hot/dep branch May 9, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Missing declared dependency to "packaging"

4 participants