Fix LuLPeg installation on Windows #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running a shell script doesn't work on Windows, even if MSYS2/MinGW is used, since
os.executestill goes throughcmd.exe, which is what LuaRocks uses to execute the build command. Instead we can run the lua script directly and also remove the implicit dependency toluajitandbashby using the$(LUA)variable luarocks provides (it isn't used anywhere right?). Technicallymake.shwould no longer be needed, but I left it there for backwardscompatibility. This doesn't require a code change so I increased only the revision number of the rockspec.