Skip to content

chore(run): replace volatile usage with DNOA #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyk merged 1 commit into from
Dec 9, 2025
Merged

chore(run): replace volatile usage with DNOA #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/fibonacci.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ pub fn main() !void {
.sample_size = 100,
.warmup_iters = 3,
};
const m_naive = try bench.run(allocator, "fibNaive", fibNaive, .{@as(u64, 30)}, opts);
const m_iter = try bench.run(allocator, "fibIterative", fibIterative, .{@as(u64, 30)}, opts);
const m_naive = try bench.run(allocator, "fibNaive", fibNaive, .{30}, opts);
const m_iter = try bench.run(allocator, "fibIterative", fibIterative, .{30}, opts);

try bench.report(.{
.metrics = &.{ m_naive, m_iter },
Expand Down
11 changes: 6 additions & 5 deletions src/root.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ pub fn run(allocator: Allocator, name: []const u8, function: anytype, args: anyt

// ref: https://pyk.sh/blog/2025-12-08-bench-fixing-constant-folding
var runtime_args = createRuntimeArgs(function, args);
const volatile_args_ptr: *volatile @TypeOf(runtime_args) = &runtime_args;
std.mem.doNotOptimizeAway(&runtime_args);

for (0..options.warmup_iters) |_| {
try execute(function, volatile_args_ptr.*);
try execute(function, runtime_args);
}

// We need to determine a batch_size such that the total execution time of the batch
Expand All @@ -63,7 +63,7 @@ pub fn run(allocator: Allocator, name: []const u8, function: anytype, args: anyt
while (true) {
timer.reset();
for (0..batch_size) |_| {
try execute(function, volatile_args_ptr.*);
try execute(function, runtime_args);
}
const duration = timer.read();

Expand All @@ -89,7 +89,7 @@ pub fn run(allocator: Allocator, name: []const u8, function: anytype, args: anyt
for (0..options.sample_size) |i| {
timer.reset();
for (0..batch_size) |_| {
try execute(function, volatile_args_ptr.*);
try execute(function, runtime_args);
}
const total_ns = timer.read();
// Average time per operation for this batch
Expand Down Expand Up @@ -142,7 +142,7 @@ pub fn run(allocator: Allocator, name: []const u8, function: anytype, args: anyt
try perf.capture();
for (0..options.sample_size) |_| {
for (0..batch_size) |_| {
try execute(function, volatile_args_ptr.*);
try execute(function, runtime_args);
}
}
try perf.stop();
Expand All @@ -168,6 +168,7 @@ pub fn run(allocator: Allocator, name: []const u8, function: anytype, args: anyt
inline fn execute(function: anytype, args: anytype) !void {
const FnType = unwrapFnType(@TypeOf(function));
const return_type = @typeInfo(FnType).@"fn".return_type.?;

// Conditional execution based on whether the function can fail
if (@typeInfo(return_type) == .error_union) {
const result = try @call(.auto, function, args);
Expand Down