-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix setting options for import order checker #10802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fix regression in 6ce6032: In `__init__` the options are not parsed yet and hence will always be the defaults.
5881284 to
6f64d53
Compare
|
Hm |
DanielNoord
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That's a stupid regression for me to make...
|
Seems there are some small things we'll need to fix |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10802 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 176 176
Lines 19564 19566 +2
=======================================
+ Hits 18779 18781 +2
Misses 785 785
π New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
fca0a2b to
e1193f4
Compare
|
@Flamefire There is unfortunately still a lint failure |
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit e1193f4 |
With the fix of honoring the config the import is now correctly identified using the overwrite `known-standard-library=_string`
That is actually in a file I didn't touch. What happened:
|
Type of Changes
Description
Fix regression in 6ce6032:
In
__init__the options are not parsed yet and hence will always be the defaults.Closes #10801
I was looking for a way to avoid this in general. However that requires a bit more refactoring to either:
PyLinter.optionson__init__.pyto detect access to it before being set (from config)