Skip to content

Use a constant copyright date#18

Open
bmwiedemann wants to merge 1 commit intopyqrcode:masterfrom
bmwiedemann:date
Open

Use a constant copyright date#18
bmwiedemann wants to merge 1 commit intopyqrcode:masterfrom
bmwiedemann:date

Conversation

@bmwiedemann
Copy link

Use a constant copyright date
because a) copyright only expires 70 years after the death of the author

and b) users might look at this string to see how current this software is
but this will be misleading when it is rebuilt later.

and c) for reproducible builds we want to be able to rebuild packages later
and still get bit-identical output. In this case, it produced diffs in

 /usr/share/doc/packages/python36-PyQRCode/html/_modules/pyqrcodeng.html
-    <p>&#169; Copyright 2013-2021, Michael Nooner, 2018 - 2021 Lars Heuer.</p>
+    <p>&#169; Copyright 2013-2021, Michael Nooner, 2018 - 2037 Lars Heuer.</p>

This PR was done while working on reproducible builds for openSUSE.

because a) copyright only expires 70 years after the death of the author

and b) users might look at this string to see how current this software is
but this will be misleading when it is rebuilt later.

and c) for reproducible builds we want to be able to rebuild packages later
and still get bit-identical output. In this case, it produced diffs in
/usr/share/doc/packages/python36-PyQRCode/html/_modules/pyqrcodeng.html
-    <p>&#169; Copyright 2013-2021, Michael Nooner, 2018 - 2021 Lars Heuer.</p>
+    <p>&#169; Copyright 2013-2021, Michael Nooner, 2018 - 2037 Lars Heuer.</p>

This patch was done while working on reproducible builds for openSUSE.
@heuer
Copy link

heuer commented Dec 21, 2021

You are probably right and I support the change. But I no longer have write access to this project and it is unmaintained, see #16

Unless it has already been added to openSUSE, I would refrain from doing so.

@bmwiedemann
Copy link
Author

https://code.opensuse.org/package/python-PyQRCode/tree/master looks like we moved to NG two weeks ago. Matej Cepl seems to have done that switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants