Skip to content

Add the ability to pass environment variables in Kubernetes format #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tkukushkin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add the ability to pass environment variables in Kubernetes format #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe6919d
Add the ability to pass environment variables in Kubernetes format
tkukushkin Jul 20, 2023
8e36e8c
small fix
tkukushkin Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chart/pyroscope/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ apiVersion: v2
name: pyroscope
description: A Helm chart for Pyroscope
type: application
version: 0.2.92
version: 0.2.93
appVersion: "0.37.2"
3 changes: 2 additions & 1 deletion chart/pyroscope/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# pyroscope

![Version: 0.2.92](https://img.shields.io/badge/Version-0.2.92-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.37.2](https://img.shields.io/badge/AppVersion-0.37.2-informational?style=flat-square)
![Version: 0.2.93](https://img.shields.io/badge/Version-0.2.93-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.37.2](https://img.shields.io/badge/AppVersion-0.37.2-informational?style=flat-square)

A Helm chart for Pyroscope

Expand Down Expand Up @@ -53,6 +53,7 @@ Please refer to [the documentation](https://pyroscope.io/docs/server-configurati
| affinity | object | `{}` | Affinity settings for pod assignment |
| deploymentStrategy | object | `{"type":"Recreate"}` | Deployment strategy |
| env | object | `{}` | Extra environment variables |
| envVars | list | `[]` | Extra environment variables in Kubernetes format, use it when you need to use `valueFrom` |
| extraLabels | object | `{}` | Extra common labels for all resources |
| extraVolumeMounts | list | `[]` | Additional volume mounts for pyroscope server container |
| extraVolumes | list | `[]` | Additional volumes |
Expand Down
5 changes: 4 additions & 1 deletion chart/pyroscope/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,15 @@ spec:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
{{- if .Values.env }}
{{- if or .Values.env .Values.envVars }}
env:
{{- range $k, $v := .Values.env }}
- name: {{ $k }}
value: {{ $v }}
{{- end }}
{{- with .Values.envVars }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- end }}
ports:
- name: api
Expand Down
8 changes: 8 additions & 0 deletions chart/pyroscope/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,14 @@ extraVolumeMounts: []
# -- Extra environment variables
env: {}

# -- Extra environment variables in Kubernetes format, use it when you need to use `valueFrom`
envVars: []
# - name: PYROSCOPE_AUTH_GOOGLE_CLIENT_ID
# valueFrom:
# secretKeyRef:
# name: pyroscope-auth-google
# key: client-id

rbac:
# -- Creates Pyroscope cluster role and binds service account to it; requires service account to be created
create: false
Expand Down