Fix type-checking error for console.render call #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0) - [github.com/astral-sh/ruff-pre-commit: v0.12.4 → v0.14.10](astral-sh/ruff-pre-commit@v0.12.4...v0.14.10) - [github.com/kynan/nbstripout: 0.8.1 → 0.8.2](kynan/nbstripout@0.8.1...0.8.2) - [github.com/executablebooks/mdformat: 0.7.22 → 1.0.0](hukkin/mdformat@0.7.22...1.0.0) - [github.com/executablebooks/mdformat: 0.7.22 → 1.0.0](hukkin/mdformat@0.7.22...1.0.0)
Add type ignore comment for console.render(traceback) call. The Traceback object is correctly renderable by rich's console, but the type checker doesn't recognize this properly.
- Add type ignore for Path() call with potentially None __file__ - Add type ignore for functools.wraps with CoiledFunction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the type-checking error in PR #120.
The issue is that the type checker doesn't recognize that
Tracebackobjects are renderable by rich'sconsole.render()method. The code is correct and works at runtime, but we need to add a type ignore comment to pass type-checking.Changes:
# ty: ignore[invalid-argument-type]to theconsole.render(traceback)call insrc/pytask_parallel/wrappers.pyThis allows PR #120 (pre-commit autoupdate) to pass all checks and be merged.