feat(insights hub): tweaked the layout and design to give more room to the chart and be better on mobile #3354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onent and used it for the feeds demo to power a mobile and desktop menu
|
The latest updates on your projects. Learn more about Vercel for GitHub. 7 Skipped Deployments
|
… occur when a chart is destroyed while a pending write is still incoming
benduran
changed the base branch from
main
to
bduran/T-minus-7-historical-playback
benduran
merged commit 87d81b1
into
bduran/T-minus-7-historical-playback
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<Popover />component, similar to the<Tooltip />, which is much easier to use than doing the whole react-aria song and dance bespoke every time<PriceCard />component (unique only to Insights hub)<Popover />to add a mobile menu to house all the tools / settings you can change on the feeds demo pageRationale
Not enough space was given for the chart. The previous design had the pricing cards being too large.
How has this been tested?
In Action
CleanShot.2026-01-09.at.11.36.13.mp4