-
-
Notifications
You must be signed in to change notification settings - Fork 738
Support unicode urls filtering #3450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Unquoting the entire URL can change the meaning of the URL quite severely. Another example: |
|
To summarize some discussion with mbaruh from Discord:
For now, we can probably replace In the future, since we really want to parse URLs in the same way JavaScript does, we could use something that explicitly parses URLs according to the whatwg rules. There's a >>> banana = "http:///////%d0%b1%d0%b0%d0%bd%d0%b0%d0%bd.com"
>>> whatwg_url.parse_url(banana)
<Url scheme='http' hostname='xn--80aab3cb.com' port=None path='/' query=None fragment=None>
>>>As an alternative we could use the Rust |
|
one of my favorite urls that discord parses weirdly is: https://github.com/0/... I also have a few others that are entirely unclickable in the client, I'll share them when I find them |
No description provided.