gh-142568: Fix eval() docs to use 'source' parameter name #142644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
docs
Member
|
CC @JelleZijlstra (Since you merged 2770d5c) |
JelleZijlstra
approved these changes
Dec 12, 2025
JelleZijlstra
added
awaiting review
needs backport to 3.13
|
Thanks @Joshua-Ward1 for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 13, 2025
…onGH-142644) (cherry picked from commit c865ab3) Co-authored-by: Joshua Ward <joshie@flewognetworks.wales>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 13, 2025
…onGH-142644) (cherry picked from commit c865ab3) Co-authored-by: Joshua Ward <joshie@flewognetworks.wales>
|
GH-142669 is a backport of this pull request to the 3.14 branch. |
|
GH-142670 is a backport of this pull request to the 3.13 branch. |
JelleZijlstra
pushed a commit
that referenced
this pull request
Dec 13, 2025
JelleZijlstra
pushed a commit
that referenced
this pull request
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an inconsistency in the documentation for
eval()where the parameterwas referred to as “expression” instead of “source”, which does not match
the function signature.
Rationale
The function signature and parameter description already use
source.Updating the prose ensures consistency and avoids confusion for readers.
Changes
Doc/library/functions.rstto consistently refer to thesourceparameter in the
eval()documentation.Testing
Not applicable — documentation-only change.
Related issue
📚 Documentation preview 📚: https://cpython-previews--142644.org.readthedocs.build/