Skip to content

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jan 12, 2026

BINARY_OP_SUBSCR_INIT_FRAME is the opcode for subscripting custom __getitem__.

LOAD_ATTR_PROPERTY is the opcode for loading an attribute decorated with @property.

I see a solid 0.5-1% speedup from this PR alone on Sam's fastmark (pyperformance subset).

@Fidget-Spinner Fidget-Spinner changed the title gh-131798: JIT: Support custom binary op and property frames gh-131798: JIT optimizer: Support custom binary op and property frames Jan 12, 2026
@savannahostrowski savannahostrowski self-requested a review January 13, 2026 04:25
@bedevere-app
Copy link

bedevere-app bot commented Jan 13, 2026

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Copy link
Member

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Fidget-Spinner Fidget-Spinner merged commit 2873c31 into python:main Jan 13, 2026
65 of 66 checks passed
@Fidget-Spinner Fidget-Spinner deleted the last_few_push_frames branch January 13, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants