-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-141004: Mark up docs of old PyMem macros #143783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Their docs-only deprecation notice appeared 2.0: https://docs.python.org/release/2.0/api/memoryInterface.html but not 1.6: https://docs.python.org/release/2.0/api/memoryInterface.html Nowadays we call this soft deprecation. Since PEP 445, they are now direct aliases; there are no (additional) binary compatibility concerns over the preferred names.
Doc/c-api/memory.rst
Outdated
| .. c:macro:: PyMem_MALLOC(size) | ||
| PyMem_NEW(type, size) | ||
| PyMem_REALLOC(ptr, size) | ||
| PyMem_RESIZE(ptr, type, size) | ||
| PyMem_FREE(ptr) | ||
| PyMem_DEL(ptr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to have a table, similar to what I did here.
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
These had a docs-only deprecation notice since the first version of the docs in this repo. Nowadays we call things “soft deprecated” if there's just a note in the docs. The deprecated directive needs a version, I went with the first one that had the notice (2.0; it's not in 1.6): - https://docs.python.org/release/2.0/api/memoryInterface.html - https://docs.python.org/release/1.6/api/memoryInterface.html Since PEP 445, they are now direct aliases; there are no (additional) binary compatibility concerns over the preferred names. (cherry picked from commit a009e78) Co-authored-by: Petr Viktorin <encukou@gmail.com>
These had a docs-only deprecation notice since the first version of the docs in this repo. Nowadays we call things “soft deprecated” if there's just a note in the docs. The deprecated directive needs a version, I went with the first one that had the notice (2.0; it's not in 1.6): - https://docs.python.org/release/2.0/api/memoryInterface.html - https://docs.python.org/release/1.6/api/memoryInterface.html Since PEP 445, they are now direct aliases; there are no (additional) binary compatibility concerns over the preferred names. (cherry picked from commit a009e78) Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
GH-143864 is a backport of this pull request to the 3.14 branch. |
|
GH-143865 is a backport of this pull request to the 3.13 branch. |
These had a docs-only deprecation notice since the first version of the docs in this repo. Nowadays we call things “soft deprecated” if there's just a note in the docs. The deprecated directive needs a version, I went with the first one that had the notice (2.0; it's not in 1.6): - https://docs.python.org/release/2.0/api/memoryInterface.html - https://docs.python.org/release/1.6/api/memoryInterface.html Since PEP 445, they are now direct aliases; there are no (additional) binary compatibility concerns over the preferred names.
These had a docs-only deprecation notice since the first version of the docs in this repo. Nowadays we call things “soft deprecated” if there's just a note in the docs.
The
deprecateddirective needs a version, I went with the first one that had the notice (2.0; it's not in 1.6).Since PEP 445, they are now direct aliases; there are no (additional) binary compatibility concerns over the preferred names.
📚 Documentation preview 📚: https://cpython-previews--143783.org.readthedocs.build/