Skip to content

Slightly refactor process_error_codes #20618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wyattscarpenter wants to merge 5 commits into
base: master
Choose a base branch
from
+11 −9
Open

Slightly refactor process_error_codes #20618

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72396a9
slight refactor
wyattscarpenter Dec 13, 2025
29e86d8
make it a real docstring
wyattscarpenter Jan 19, 2026
fdaa8f8
typo
wyattscarpenter Jan 19, 2026
515e83f
punc
wyattscarpenter Jan 19, 2026
1827738
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions mypy/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,18 +456,20 @@ def __repr__(self) -> str:
return f"Options({pprint.pformat(self.snapshot())})"

def process_error_codes(self, *, error_callback: Callable[[str], Any]) -> None:
# Process `--enable-error-code` and `--disable-error-code` flags
disabled_codes = set(self.disable_error_code)
enabled_codes = set(self.enable_error_code)
"""Process `--enable-error-code` and `--disable-error-code` flags."""
disabled_code_names = set(self.disable_error_code)
enabled_code_names = set(self.enable_error_code)

valid_error_codes = set(error_codes.keys())
valid_error_code_names = set(error_codes.keys())

invalid_codes = (enabled_codes | disabled_codes) - valid_error_codes
if invalid_codes:
error_callback(f"Invalid error code(s): {', '.join(sorted(invalid_codes))}")
invalid_code_names_here = (
enabled_code_names | disabled_code_names
) - valid_error_code_names
if invalid_code_names_here:
error_callback(f"Invalid error code(s): {', '.join(sorted(invalid_code_names_here))}")

self.disabled_error_codes |= {error_codes[code] for code in disabled_codes}
self.enabled_error_codes |= {error_codes[code] for code in enabled_codes}
self.disabled_error_codes |= {error_codes[code] for code in disabled_code_names}
self.enabled_error_codes |= {error_codes[code] for code in enabled_code_names}

# Enabling an error code always overrides disabling
self.disabled_error_codes -= self.enabled_error_codes
Expand Down