Fix different linkage error with cp313-win#136
Closed
cdce8p wants to merge 1 commit intopython:mainfrom
Closed
Conversation
Contributor
Author
|
/CC @vstinner |
Member
|
This issue should be fixed by the change c84545f : can you please try the fix in mypy CI? |
Contributor
Author
Thanks! My test setup looks fine. Opened python/mypy#18560 for mypy. |
Member
|
Oh! I misread this pull request. I saw it as an issue and I wrote exactly the same fix :-D Sorry, I could merge your PR directly. |
Contributor
Author
It's fixed now. https://github.com/mypyc/mypy_mypyc-wheels/actions/runs/13014956712/job/36301735749 |
Member
|
Thabks again for your bug report and your fix @cdce8p! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems there was one another regression. Our the
cp313-winwheel build started to fail after thepythoncapi_compat.hupdate was merged. We don't test every platform version combination in CI, that's why I missed it initially.Seems like a similar issue to #115 where MSVC requires that the signatures match the upstream ones exactly.
Also updated
_Py_fopen_objeven though that didn't fail for us. Probably just because we don't usePy_fopenyet.